Skip to content

Add Regex.Match.subscript(_: Reference) to DSL pitch. #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 17, 2022
Merged

Add Regex.Match.subscript(_: Reference) to DSL pitch. #212

merged 1 commit into from
Mar 17, 2022
+7 −4

Conversation

rxwei
Copy link
Contributor

@rxwei rxwei commented Mar 17, 2022

Given that the Regex type pitch is going to include the Regex.Match type, we add the extension that contains subscript(_: Reference) to the DSL pitch. Also fix the Reference code example.

@rxwei
Add Regex.Match.subscript(_: Reference) to DSL pitch.
0db0ce6 
Given that the `Regex` type pitch is going to include the `Regex.Match` type, we add the extension that contains `subscript(_: Reference)` to the DSL pitch. Also fix the `Reference` code example.
@rxwei rxwei requested a review from milseman March 17, 2022 07:11
@rxwei
Copy link
Contributor Author

rxwei commented Mar 17, 2022

@swift-ci please test Linux

@rxwei rxwei merged commit b68a030 into swiftlang:main Mar 17, 2022
@rxwei rxwei deleted the dsl-pitch-matchresult branch March 17, 2022 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milseman milseman Awaiting requested review from milseman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rxwei